Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erc1155 to token gating group conditions #1381

Closed
wants to merge 1 commit into from

Conversation

kalashshah
Copy link
Contributor

Fixes Issue

Closes #1380

Changes proposed

  • Add ERC1155 as one of the token gating conditions in groups
  • Support UI changes

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link

In the package.json file:

  1. The "peerDependencies" should be closed with a closing brace '}' after the last dependency.
  2. The "devDependencies" section should be closed with a closing brace '}' after the last dev dependency.
  3. There is a missing comma after "styled-components": "^6.0.8".
  4. The version of react is specified as ">=16.8.0" which should be without the greater than sign: "16.8.0".

For the AddCriteria.tsx file:

  1. The import statements for helper functions should be corrected with commas separating each function.
  2. There is a missing closing curly brace '}' after the error handling block.
  3. There seems to be an issue with the structure and logic of setting different category values in the dropdowns.

Overall, there seem to be multiple issues related to syntax, organization, and logic that need addressing.

Please correct these issues and re-run the code for further review.

@abhishek-01k
Copy link
Collaborator

Screenshot 2024-08-01 at 5 13 37 PM

Is this UI correct?

@kalashshah
Copy link
Contributor Author

Screenshot 2024-08-01 at 5 13 37 PM Is this UI correct?

https://www.figma.com/design/FvJL0JWHlsVohsHTERB1Lh/Push-Design-Foundations-%5BFuture%5D?node-id=5862-32769&t=6TJkYbnklLVUd76p-1

@abhishek-01k
Copy link
Collaborator

LGTM 👍🏻

@rohitmalhotra1420 rohitmalhotra1420 changed the base branch from main to alpha August 5, 2024 09:58
@kalashshah kalashshah changed the base branch from alpha to main August 5, 2024 10:00
@kalashshah kalashshah closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Introduce ERC1155 and token id support in group creation modal
2 participants